[MNG-6698] Improve the ManagedVersionMap #263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This map is not used by maven and the computation can be quite heavy, so lazy compute it. In addition, do not clone the map, as it's an unmodifiable one.
|
While I understand the diff, I don't understand "This map is not used by maven". Who uses this map? Plugins? Other components from our ecosystem? |
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2019
This map is not used by Maven and the computation can be quite heavy, so lazily compute it. In addition, do not clone the map, as it's an unmodifiable one already. This closes #263
asfgit
pushed a commit
that referenced
this pull request
Jul 6, 2019
This map is not used by Maven and the computation can be quite heavy, so lazily compute it. In addition, do not clone the map, as it's an unmodifiable one already. This closes #263
michael-o
approved these changes
Jul 6, 2019
Mostly plugins I suppose, what I meant is that maven-core itself does not use it. |
|
Alright, that's what I understood. |
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2019
This map is not used by Maven and the computation can be quite heavy, so lazily compute it. In addition, do not clone the map as it's an unmodifiable one already. This closes #263
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
…che#263) Co-authored-by: Giovanni van der Schelde <Giovanni.vanderSchelde@infosupport.com> Co-authored-by: Giovanni van der Schelde <gvdschelde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.