Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNG-5486 hiding transfer logs #28

Closed
wants to merge 1 commit into from
Closed

MNG-5486 hiding transfer logs #28

wants to merge 1 commit into from

Conversation

martin-g
Copy link
Member

The latest patch from https://jira.codehaus.org/browse/MNG-5486 as a Pull Request as requested by Jason van Zyl.

@JigarJoshi
Copy link

+1

@hboutemy
Copy link
Member

I like the idea of quiet transfert
but does it deserve an additional option: shouldn't this quiet transfert be activated in existing batch mode = non-interactive = no input, but limited output too

WDYT?

@@ -137,6 +139,7 @@ public CLIManager()
options.addOption( OptionBuilder.withLongOpt( "encrypt-master-password" ).hasOptionalArg().withDescription( "Encrypt master security password" ).create( ENCRYPT_MASTER_PASSWORD ) );
options.addOption( OptionBuilder.withLongOpt( "encrypt-password" ).hasOptionalArg().withDescription( "Encrypt server password" ).create( ENCRYPT_PASSWORD ) );
options.addOption( OptionBuilder.withLongOpt( "threads" ).hasArg().withDescription( "Thread count, for instance 2.0C where C is core multiplied" ).create( THREADS ) );
options.addOption( OptionBuilder.withLongOpt( "quiet_transfer_logs" ).withDescription( "quiets transfer logs, for example: downloading, uploading, bytes downloaded, etc.." ).create( QUIET_TRANSFER_LOGS) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"quiet-transfer-logs", for consistency with other options, please

@michael-o
Copy link
Member

Why do we need this? There is a batch mode, minimal transfer output.

@martin-g
Copy link
Member Author

@michael-o I think even quiet should/could prevent logging the transfer output.
I just created a PR with the provided patch as requested by Jason van Zyl in the ticket to help with its processing.
Feel free to improve it as you believe it would be the best!

@michael-o
Copy link
Member

@martin-g, quiet implementation logs nothing. It is a no-op. So it does what you want. What improvement are you trying to make here?
@jvanzyl, can you share some thoughts?

@jvanzyl
Copy link
Contributor

jvanzyl commented Nov 15, 2014

@martin-g does the quiet option provide the behaviour you'd like?

@martin-g
Copy link
Member Author

@jvanzyl Yes. I don't need the new option.

@martin-g martin-g closed this Nov 17, 2014
@JigarJoshi
Copy link

quiet option is too quiet, I originally wanted just to hide the transfer logs, sometime it can be annoying in CI systems

@michael-o
Copy link
Member

@JigarJoshi , you can use batch mode for that.

pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
Adds a sentence that explains what happens to plugin declarations which
load extensions.
pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
…n-docs

Resolve apache#28: Improve Javadoc for flatten goal
gnodet pushed a commit to gnodet/maven that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants