Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNG-5909 : Add combined expression evaluator to file activation property #92

Closed
wants to merge 1 commit into from
Closed

MNG-5909 : Add combined expression evaluator to file activation property #92

wants to merge 1 commit into from

Conversation

lbndev
Copy link

@lbndev lbndev commented Aug 17, 2016

Suggested solution for MNG-5909 : the file activation element will understand basic boolean expressions such as and(file1,file2) or(file3,!file4) etc... Please see added unit test for expression examples.
If you think this could benefit to other activators (property, os, ...) please say so and I will happily modify them too.
I will also post a message on maven dev mailing list.

@kwin
Copy link
Member

kwin commented Jun 29, 2018

@lbndev Can you redo the PR only containing the actual change (IIUC this is only commit 2efe3d2). Otherwise it is impossible to review.

@lbndev
Copy link
Author

lbndev commented Jul 27, 2018

Hello @kwin,

Wow, resurrecting an old request !
I rebased my change on branch "pre-reset-master" (see branch MNG-5909-oldmaster), then I cherry-picked in on top of the new master, fixing conflicts.

It used to work on the initial version of this PR (almost 2 years ago), but I should take time to build & test this new version just to make sure it plays nicely with all the other changes in maven over the last 2 years. Maybe I'll find time during the weekend.

Thanks for your interrest in this PR

Loïc

@bdelion
Copy link

bdelion commented Jul 10, 2019

UP

@michael-o
Copy link
Member

This does not incur a model change, does it?

@marcelstoer
Copy link

Any chance this will ever be accepted?

@michael-o
Copy link
Member

I will try to look at this in the next two weeks.

@michael-o
Copy link
Member

@marcelstoer Please ping me by mid of April.

@marcelstoer
Copy link

Please ping me by mid of April.

Ping

@michael-o
Copy link
Member

Please ping me by mid of April.

Ping

Seriously? Do you live a by different calendar? You consider 2021-04-05 mid of April?

@marcelstoer
Copy link

Not sure what the intention of this comment was (i.e. why I should ping you) but "by mid April" means no later than mid April. You meant "around" mid April instead?

pzygielo pushed a commit to pzygielo/maven that referenced this pull request Jan 4, 2023
@saturnism @hohwille
apache#92: Introduce new Flatten Dependency Mode to flatten all trans…
04d44a8 
…itive dependencies (apache#93)
@trydofor trydofor mentioned this pull request Mar 1, 2023
Closed
@gnodet
Copy link
Contributor

gnodet commented Oct 4, 2024

Superseded by #1771

@gnodet gnodet closed this Oct 4, 2024
gnodet pushed a commit to gnodet/maven that referenced this pull request Nov 20, 2024
@michael-o
[MNG-6114] Elements from the global settings should be ordered before…
218ce6c 
… elements from the user settings

Central from global settings with 'file:' comes first and is ignored by the
mirrorOf definition. The next central definition is ignored too due to
MNG-7018/MNG-5984. As long as these issues aren't resolved we need to mirror
even local repos to make the IT work as intended.

This closes apache#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lbndev @kwin @bdelion @michael-o @marcelstoer @gnodet