Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7672] Fork should only execute the project and its submodules #968

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jan 26, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gnodet gnodet requested a review from michael-o January 26, 2023 07:36
@pzygielo
Copy link
Contributor

Just about vocabulary.
Commit comment and JIRA issue mention children.
Code is about aggregator and submodules.
As I understand it - being submodule does not mean anything about being child, and is not related with inheritance. Perhaps this could be re-worded to not mix the two.


https://maven.apache.org/pom.html#a-final-note-on-inheritance-v-aggregation

@gnodet gnodet changed the title [MNG-7672] Fork should only execute the project and its children [MNG-7672] Fork should only execute the project and its submodules Jan 26, 2023
@cstamas
Copy link
Member

cstamas commented Jan 27, 2023

Interesting fact; this PR fixes code added to Maven 3.0-RC1 (!!!) but the Javadoc for aggregator says literally this what this PR introduces (so the two was not aligned since 3.0-RC1): https://maven.apache.org/ref/3.8.7/maven-plugin-api/apidocs/org/apache/maven/plugin/descriptor/MojoDescriptor.html#isAggregator--

@gnodet
Copy link
Contributor Author

gnodet commented Jan 27, 2023

Interesting fact; this PR fixes code added to Maven 3.0-RC1 (!!!) but the Javadoc for aggregator says literally this what this PR introduces (so the two was not aligned since 3.0-RC1): https://maven.apache.org/ref/3.8.7/maven-plugin-api/apidocs/org/apache/maven/plugin/descriptor/MojoDescriptor.html#isAggregator--

Yes, I saw the javadoc for the isAggregator and it guided me in finding this fix !

@cstamas
Copy link
Member

cstamas commented Jan 30, 2023

So, what is the status of this (am more interested in 3.9 backport), is this fix confirmed? When is merge expected?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 30, 2023

So, what is the status of this (am more interested in 3.9 backport), is this fix confirmed? When is merge expected?

#969 and #970
I think @michael-o wanted to review this PR, right ?

@gnodet gnodet merged commit 30fafa6 into apache:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants