Skip to content

Commit

Permalink
Revert "Updated Bouncycastle libraries version to 1.78"
Browse files Browse the repository at this point in the history 
This reverts commit c237cdf.

Bouncy Castle 1.78 has broken OSGi metadata: the package imports in
MANIFEST.MF are missing. See also [1] and [2].

[1] bcgit/bc-java#1621
[2] eclipse-platform/eclipse.platform.releng.aggregator#1968 (comment)
  • Loading branch information
@tomaswolf
tomaswolf committed Apr 10, 2024
1 parent c237cdf commit 69b64da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@

<min.required.maven.version>3.5.0</min.required.maven.version>
<groovy.version>4.0.17</groovy.version>
<bouncycastle.version>1.78</bouncycastle.version>
<bouncycastle.version>1.77</bouncycastle.version>
<!-- NOTE: upgrading slf4j beyond this version causes
Execution verify-style of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check failed.: NullPointerException
Expand Down

3 comments on commit 69b64da

@merks
Copy link

@merks merks commented on 69b64da Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 1.78 just kind of broken?😞

@tomaswolf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Did you read the commit message?

@merks
Copy link

@merks merks commented on 69b64da Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but during dinner. Matthias gives his greeting.

Please sign in to comment.