GH-597: pass on Charset in ClientSession.executeRemoteCommand()

Bug: #597
apache · Sep 7, 2024 · 8db5cad · 8db5cad
1 parent 7fa206f
commit 8db5cad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -43,6 +43,7 @@
 * [GH-582](https://github.com/apache/mina-sshd/issues/582) Fix filtering in `NamedFactory`
 * [GH-587](https://github.com/apache/mina-sshd/issues/587) Prevent `NullPointerException`on closed channel in `NettyIoSession`
 * [GH-590](https://github.com/apache/mina-sshd/issues/590) Better support for FIPS
+* [GH-597](https://github.com/apache/mina-sshd/issues/597) Pass on `Charset` in `ClientSession.executeRemoteCommand()`
 
 ## New Features
 

diff --git a/sshd-core/src/main/java/org/apache/sshd/client/session/ClientSession.java b/sshd-core/src/main/java/org/apache/sshd/client/session/ClientSession.java
@@ -301,7 +301,7 @@ default void executeRemoteCommand(
 
         try (OutputStream channelErr = (stderr == null) ? new NullOutputStream() : new NoCloseOutputStream(stderr);
              OutputStream channelOut = (stdout == null) ? new NullOutputStream() : new NoCloseOutputStream(stdout);
-             ClientChannel channel = createExecChannel(command)) {
+             ClientChannel channel = createExecChannel(command, charset, null, Collections.emptyMap())) {
             channel.setOut(channelOut);
             channel.setErr(channelErr);
             channel.open().await(); // TODO use verify and a configurable timeout