Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mina full class name in BuiltinIoServiceFactoryFactories #511

Closed
wants to merge 1 commit into from
Closed

Fix mina full class name in BuiltinIoServiceFactoryFactories #511

wants to merge 1 commit into from

Conversation

JinHeap
Copy link
Contributor

@JinHeap JinHeap commented May 30, 2024

Addresses #510

@tomaswolf
Copy link
Member

Thanks. The change is good, but now that this is fixed DefaultIoServiceFactoryFactoryTest hangs for MINA during disposal of the partially set up (with mocks) MinaServiceFactory. Previously it just skipped the non-existing class.

Also, BuiltinIoServiceFactoryFactoriesTest should have a test that fails if one of the enum constants has a wrong class name. I.e., a test that would have uncovered the original problem (wrong string).

I'll see if I can amend this commit to fix these test issues.

@JinHeap
Copy link
Contributor Author

JinHeap commented May 31, 2024

thanks. then if need me do something, please tell me.

@JinHeap @tomaswolf
apacheGH-510: Fix class name in BuiltinIoServiceFactoryFactories
422e46f 
The class name for the MinaServiceFactoryFactory was not updated in the
refactoring in commit 5cbae28.

Add a test that catches such mistakes, and exclude another test
from being run with the MinaServiceFactoryFactory because it cannot
work with a mocked ExecutorService.

Bug: apache#510
@tomaswolf
Copy link
Member

Merged as commit 82e0ed1.

@tomaswolf tomaswolf closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JinHeap @tomaswolf