Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to be able to use BCFIPS when BC is blocked in a FIPS environment #589

Closed
wants to merge 2 commits into from
Closed

Add option to be able to use BCFIPS when BC is blocked in a FIPS environment #589

wants to merge 2 commits into from

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 30, 2024 •
edited
Loading

When using using registar created for BCFIPS (which means any BC classes are available within the class path).

I got

java.lang.IllegalArgumentException: BouncyCastle not registered
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.util.ValidateUtils.createFormattedException(ValidateUtils.java:213)
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:179)
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:156)
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.util.security.SecurityUtils.getBouncycastleEncryptedPrivateKeyInfoDecryptor(SecurityUtils.java:553)
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.config.keys.loader.pem.PKCS8PEMResourceKeyPairParser.decryptKeyPairs(PKCS8PEMResourceKeyPairParser.java:107)

I tried to "trick" it :) using the name BC here https://github.com/jenkinsci/mina-sshd-api-plugin/pull/114/files#diff-5440105bdcdf53b86acce84166b9884f497eb6908da1d68b82ec974aa0fd83e1R45

But turns into:

  Caused: java.lang.NoClassDefFoundError: org/bouncycastle/crypto/prng/RandomGenerator
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.util.security.bouncycastle.BouncyCastleRandomFactory.create(BouncyCastleRandomFactory.java:43)
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.util.security.bouncycastle.BouncyCastleRandomFactory.create(BouncyCastleRandomFactory.java:28)
  at PluginClassLoader for mina-sshd-api-common//org.apache.sshd.common.random.SingletonRandomFactory.<init>(SingletonRandomFactory.java:38)

with BCFIPS (classic BC class not available in the classpth) this is this class https://javadoc.io/doc/org.bouncycastle/bc-fips/latest/org/bouncycastle/crypto/fips/FipsSecureRandom.html

But the idea is to make this random factory more configurable.

@olamy
Add option to be able to use BCFIPS when BC is blocked in a FIPS envi…
5ece4cf 
…ronment

Signed-off-by: Olivier Lamy <olamy@apache.org>
This was referenced Aug 30, 2024
Merged
Closed
@olamy
Copy link
Member Author

olamy commented Aug 31, 2024

Fix #590

@olamy
use ServiceLoader to get a RandomFactory
3bc2a69 
Signed-off-by: Olivier Lamy <olamy@apache.org>
tomaswolf
tomaswolf reviewed Sep 2, 2024
View reviewed changes
sshd-common/src/main/java/org/apache/sshd/common/util/security/SecurityUtils.java
} catch (ReflectiveOperationException e) {
throw new IllegalArgumentException("instance of " + factoryClassName + " cannot be created");
}
RandomFactory randomFactory = ServiceLoader.load(RandomFactory.class).iterator().next();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to handle the case that no such service is available.

@olamy
Copy link
Member Author

olamy commented Sep 2, 2024

closing in favour of #591

@olamy olamy closed this Sep 2, 2024
@olamy olamy deleted the security-provider-bcfips branch September 2, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaswolf tomaswolf tomaswolf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @tomaswolf