This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
_backward_softsign activation is incorrect #10868
Comments
samskalicky
pushed a commit
to samskalicky/incubator-mxnet
that referenced
this issue
Jul 19, 2018
problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh
7 tasks
samskalicky
pushed a commit
to samskalicky/incubator-mxnet
that referenced
this issue
Jul 19, 2018
problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces
anirudh2290
pushed a commit
that referenced
this issue
Jul 20, 2018
* fix for bug #10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh * fix for bug #10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces * rerunning the CI build * fixed size checks for when USE_MKLDNN=ON
@eric-haibin-lin Should be good for closing as the fix was just merged? |
KellenSunderland
pushed a commit
to KellenSunderland/incubator-mxnet
that referenced
this issue
Jul 21, 2018
…pache#11827) * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces * rerunning the CI build * fixed size checks for when USE_MKLDNN=ON
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this issue
Aug 29, 2018
…pache#11827) * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh * fix for bug apache#10868: _backward_softsign activation is incorrect problem was that softsign was computed using outputs instead of inputs added inputs to list, and changed what gets passed into softsign calculation added softsign test to test_activation function code reviewed by anirudh **amended to change tab to spaces * rerunning the CI build * fixed size checks for when USE_MKLDNN=ON
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The following test case will fail:
Adding modify the test case in https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L5867
Reason: For y = softsign(x), the inputs for _backward_softsign and _backward_Activation are different:
_backward_softsign takes (dy, x) as input, backward_Activation takes (dy, y) as input.
@nswamy
The text was updated successfully, but these errors were encountered: