Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Bumping down minimum java support from 8 to 7 #12965

Merged
merged 1 commit into from
Oct 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ public void testObjectReleaseFromList() {
}

assertEquals(list.size() , 10);
list.forEach(n -> assertTrue(n.verifyIsDisposed()));
for (TestNDArray item : list) {
assertTrue(item.verifyIsDisposed());
}
}

@Test
Expand All @@ -87,7 +89,9 @@ public void testObjectReleaseFromMap() {
}

assertEquals(stringToNDArrayMap.size(), 10);
stringToNDArrayMap.forEach((key, value) -> assertTrue(value.verifyIsDisposed()));
for (Map.Entry<String, TestNDArray> entry : stringToNDArrayMap.entrySet()) {
assertTrue(entry.getValue().verifyIsDisposed());
}

Map<TestNDArray, String> ndArrayToStringMap = new HashMap<>();

Expand All @@ -98,7 +102,9 @@ public void testObjectReleaseFromMap() {
}

assertEquals(ndArrayToStringMap.size(), 10);
ndArrayToStringMap.forEach((key, value) -> assertTrue(key.verifyIsDisposed()));
for (Map.Entry<TestNDArray, String> entry : ndArrayToStringMap.entrySet()) {
assertTrue(entry.getKey().verifyIsDisposed());
}

}
}
4 changes: 2 additions & 2 deletions scala-package/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.3</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
<source>1.7</source>
<target>1.7</target>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
Expand Down