Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy-compatible stack upstream #15842

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Aug 10, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Numpy-compatible stack implementation.
  • Unit tests

Comments

@haojin2 haojin2 requested a review from szha as a code owner August 10, 2019 06:27
@haojin2 haojin2 requested review from reminisce and removed request for szha August 10, 2019 06:28
@haojin2 haojin2 self-assigned this Aug 10, 2019
@haojin2 haojin2 added the Numpy label Aug 10, 2019
@haojin2 haojin2 force-pushed the np_stack_master branch 5 times, most recently from 607cbed to 2cce6e4 Compare August 17, 2019 21:34
Copy link
Contributor

@zoeygxy zoeygxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reminisce reminisce merged commit 8eb0f61 into apache:master Aug 18, 2019
@haojin2 haojin2 deleted the np_stack_master branch August 19, 2019 00:09
larroy added a commit to larroy/mxnet that referenced this pull request Aug 20, 2019
larroy added a commit to larroy/mxnet that referenced this pull request Aug 20, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants