Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Fix incorrect calculation results when the C locale is set to a locale that uses commas as the decimal separator #17177

Merged
merged 6 commits into from
Apr 24, 2020
Merged

[1.x] Fix incorrect calculation results when the C locale is set to a locale that uses commas as the decimal separator #17177

merged 6 commits into from
Apr 24, 2020

Commits on Apr 23, 2020

  1. Add a test for floating point parsing locale invariance

    @nickguletskii
    nickguletskii committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    3e6accd View commit details
    Browse the repository at this point in the history

  2. Use locale-invariant dmlc:stod/stof instead of std:stod/stof

    @nickguletskii
    nickguletskii committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    5dbac9b View commit details
    Browse the repository at this point in the history

  3. Change the new operator tutorial to use dmlc:stod instead of std::stod

    @nickguletskii
    nickguletskii committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    fdef409 View commit details
    Browse the repository at this point in the history

  4. Rename locale invariance test

    @nickguletskii
    nickguletskii committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    c188f76 View commit details
    Browse the repository at this point in the history

  5. Skip test_scalarop_locale_invariance if the locales aren't available

    @nickguletskii
    nickguletskii committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    df910dd View commit details
    Browse the repository at this point in the history

  6. Fix linter errors due to incorrect include order

    @nickguletskii
    nickguletskii committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    0b13736 View commit details
    Browse the repository at this point in the history