Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix mshadow broken basic_stream example #17373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

litaotju
Copy link
Contributor

@litaotju litaotju commented Jan 18, 2020

Description

The NewTensor and NewStream API had changed to different signatures while the basic_stream.cu sample still use the incorrect interface.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [x ] Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

…API signature has changed the sample was not updated.
@litaotju litaotju requested a review from szha as a code owner January 18, 2020 09:05
Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests to confirm the change?

@litaotju
Copy link
Contributor Author

litaotju commented Jan 19, 2020

Any tests to confirm the change?

@ChaiBapchya
Tested with the following edited config.mk. The sample only compiled when USE_CUDA=1.
Since not all user use CUDA, I didn't make it on-by-default.

diff --git a/3rdparty/mshadow/guide/config.mk b/3rdparty/mshadow/guide/config.mk
index 26431bb06..9ebc4f685 100644
--- a/3rdparty/mshadow/guide/config.mk
+++ b/3rdparty/mshadow/guide/config.mk
@@ -13,21 +13,22 @@
 #----------------------------------------------------------------------------------------

 # whether use CUDA during compile
-USE_CUDA = 0
+USE_CUDA = 1

 # add the path to CUDA libary to link and compile flag
 # if you have already add them to enviroment variable, leave it as NONE
-USE_CUDA_PATH = NONE
+USE_CUDA_PATH = /usr/local/cuda

 #
 # choose the version of blas you want to use
 # can be: mkl, blas, atlas, openblas, apple
-USE_BLAS = blas
+USE_BLAS = mkl
 #
 # add path to intel library, you may need it
 # for MKL, if you did not add the path to enviroment variable
 #
-USE_INTEL_PATH = NONE
+USE_INTEL_PATH = /opt/intel/
+USE_STATIC_MKL = NONE

 # whether compile with parameter server
 USE_DIST_PS = 0
(END)

Complete config.mk is here.
https://gist.github.com/litaotju/5954a59cf9d4f4b0f3daf22a58794426

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Mar 14, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 23, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 2, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 16, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 27, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants