This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roywei
approved these changes
Jan 18, 2020
ChaiBapchya
approved these changes
Jan 19, 2020
nitpick typo in the title :p |
Yes, I approved. Thx @eric-haibin-lin |
roywei
reviewed
Jan 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed to mention we need to add this file in license check exclusion. As it's using normal Apache2.0 instead of ASF license header.
Please add the file path in the following 2 files to exclude from header check:
https://github.com/apache/incubator-mxnet/blob/master/tools/license_header.py#L64
https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/apache_rat_license_check/rat-excludes#L78
ChaiBapchya
approved these changes
Jan 24, 2020
@roywei could you cherry-pick this to 1.6.x? |
roywei
added a commit
to roywei/incubator-mxnet
that referenced
this pull request
Jan 28, 2020
* fix cpp predcit license * add white list (apache#210) * fix white list (apache#211) Co-authored-by: Lai Wei <royweilai@gmail.com>
szha
pushed a commit
that referenced
this pull request
Jan 29, 2020
* Update NOTICE to fix copyright years (#17330) * Update LICENSE for fonts (#17365) * license np_einsum file under bsd (#17367) * license under bsd * fix rat exclude * remove unused file with license issue (#17371) * [LICENSE] fix cpp predcit license (#17377) * fix cpp predcit license * add white list (#210) * fix white list (#211) Co-authored-by: Lai Wei <royweilai@gmail.com> * add disclaimer (#17428) * add disclaimer * add white list * fix exclude * remove disclaimer * update tools/pip Co-authored-by: Haibin Lin <linhaibin.eric@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the license to apache 2.0.
@skylook could you approve it?
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments