-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[OpPerf] Consolidate array manipulation related operators #17487
Conversation
d8cac88
to
f5ab204
Compare
All 5 categories
Results
|
@mxnet-label-bot add [pr-awaiting-review] |
4228baa
to
abcfa09
Compare
benchmark/opperf/README.md
Outdated
@@ -72,6 +73,8 @@ python incubator-mxnet/benchmark/opperf/opperf.py --output-format json --output- | |||
|
|||
3. **dtype** : By default, `float32`. You can override and set the global dtype for all operator benchmarks. Example: --dtype float64. | |||
|
|||
4. **profiler** : By default, 'native'. You can override and set the global profiler for all operator benchmarks. Example: --profiler 'python'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does native
mean? Could you be more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native profiler uses the MXNet's default profiler function
Python uses python's time-it function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know what it means. Could you provide more information to first time users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a line. @apeforest
A small comment. Otherwise LGTM. Please rebase as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few notes about changes I made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please this list - https://github.com/apache/incubator-mxnet/tree/master/benchmark/opperf/nd_operations
@sandeep-krishnamurthy updated |
CPU : Entire OpPerf suite |
* add shape manipulation, array expanding ops * split as alias of SliceChannel * add rounding ops * add profiler param to function description * add params, improve readability of prepare op input logic, improve opperf readme * fix index merge issue * add join,split ops * minor fixes in join,split * fix if else logic issue, lint * add comment on profiler, remove all completed ops, add res of 2 ops i missed in previous PR * remove unreachable if statements
* add shape manipulation, array expanding ops * split as alias of SliceChannel * add rounding ops * add profiler param to function description * add params, improve readability of prepare op input logic, improve opperf readme * fix index merge issue * add join,split ops * minor fixes in join,split * fix if else logic issue, lint * add comment on profiler, remove all completed ops, add res of 2 ops i missed in previous PR * remove unreachable if statements
Description
Rename array_rearrange.py file to array_manipulation_operators because there are 4 categories that we identified
Accordingly operators that didn't fall in previous existing categories (unary/binary/etc) have been allocated to these 4 categories as found meaningful.
These are the groupings
Array Rearrange Operators
Array Shape Manipulation Operators
Array Expanding Operators
Array Rounding Operators
Array Join & Split Operators
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes