This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[CD] update pypi description, setup.py #17681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szha
force-pushed
the
fix_cd_nightly
branch
3 times, most recently
from
7c70751
to
550fd21
Compare
|
retriggered unix gpu |
leezu
reviewed
Mar 3, 2020
leezu
reviewed
Mar 3, 2020
szha
force-pushed
the
fix_cd_nightly
branch
2 times, most recently
from
8d14549
to
5401db5
Compare
…t link for nightly
leezu
reviewed
Mar 6, 2020
tools/pip/setup.py
Outdated
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| if platform.system() == 'Linux': | |||
| sys.argv.append('--universal') | |||
| sys.argv.append('--plat-name=manylinux1_x86_64') | |||
| sys.argv.append('--plat-name=manylinux2010_x86_64') | |||
There was a problem hiding this comment.
Looking at the symbols in libmxnet.so, for GLIBCXX the highest version used is GLIBCXX_3.4.19 _ZNSt6chrono3_V212system_clock3nowEv and for GLIBC GLIBC_2.16 __poll_chk.
Those versions are not allowed in manylinux2010. However, they are allowed in manylinux2014.
Reference: https://www.python.org/dev/peps/pep-0571/ https://www.python.org/dev/peps/pep-0599/
Until the CD is set up to build correctly for manylinux2010, I suggest to change this line to 2014.
leezu
reviewed
Mar 6, 2020
leezu
approved these changes
Mar 13, 2020
MoisesHer
pushed a commit
to MoisesHer/incubator-mxnet
that referenced
this pull request
Apr 10, 2020
* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl>
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl>
mseth10
pushed a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Jun 2, 2020
* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl>
mseth10
pushed a commit
to mseth10/incubator-mxnet
that referenced
this pull request
Jun 2, 2020
* update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl>
This was referenced Jun 2, 2020
leezu
added a commit
that referenced
this pull request
Jun 9, 2020
* Fix CD (#17776) * Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by #17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by #16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by #15990 * [CD] update pypi description, setup.py (#17681) * update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl> * reverting .so path as per MAKE flow Co-authored-by: Leonard Lausen <lausen@amazon.com> Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Leonard Lausen <leonard@lausen.nl>
leezu
added a commit
that referenced
this pull request
Jun 15, 2020
* Fix CD (#17776) * Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by #17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by #16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by #15990 * [CD] update pypi description, setup.py (#17681) * update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl> * reverting .so path as per MAKE flow Co-authored-by: Leonard Lausen <lausen@amazon.com> Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Leonard Lausen <leonard@lausen.nl>
ChaiBapchya
pushed a commit
to ChaiBapchya/mxnet
that referenced
this pull request
Aug 15, 2020
* Fix CD (apache#17776) * Fix cd/mxnet_lib/dynamic/Jenkins_pipeline.groovy Fixes a regression in CD introduced by apache#17645 * Fix whitespace * Add NATIVE_ADDITIONAL.md Fixes a regression in CD introduced by apache#16899 * Update other $TYPE_ADDITIONAL.MD * Fix cd/python/docker Fixes regression introduced by apache#15990 * [CD] update pypi description, setup.py (apache#17681) * update pypi description, setup.py, use manylinux2010, use unified dist link for nightly * Use manylinux2014 Co-authored-by: Leonard Lausen <leonard@lausen.nl> * reverting .so path as per MAKE flow Co-authored-by: Leonard Lausen <lausen@amazon.com> Co-authored-by: Sheng Zha <szha@users.noreply.github.com> Co-authored-by: Leonard Lausen <leonard@lausen.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update pypi description, setup.py
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes