-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Website 2.0] Fix RVM version to satisfy Jekyll build in v1.x #18016
Conversation
Hey @connorgoggins , Thanks for submitting the PR
CI supported jobs: [miscellaneous, centos-cpu, unix-gpu, centos-gpu, sanity, unix-cpu, edge, windows-gpu, website, windows-cpu, clang] Note: |
@mxnet-label-bot add [pr-awaiting-review] |
@mxnet-label-bot add [Website] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for fixing it.
Wanted clarification on why 1.x branch started failing now after your website PRs got merged?
That'll explain why #17993 PR also saw this failure with 0 code change between the subsequent commits.
@aaronmarkham maybe you can help.
@ChaiBapchya my hypothesis is that the RVM package was updated to include a new release version (>2.6.3) sometime in the last couple of days. Since the previous RVM install code didn't specify a package version to install but required 2.6.3 to be used, once the higher-order version became available it was installed by default and the required lower-order version was not found, leading to the error being thrown. Just to clarify, my PRs did not introduce this error - they actually fixed it (in master). This was an issue introduced in the past (since the dependency wasn't pinned for install but a specific version was required for runtime) that didn't surface until RVM released a new version of the package. While adding the version dropdown, I noticed the problem in master and added a fix to my PR. The reason the other branches are failing is because I only added the fix for master, and the other branches (which also rely on the RVM package) did not have the benefit of my fix. |
@connorgoggins looks like 2.6.3 breaks the build |
@ChaiBapchya 2.6.3 doesn't break the build. What breaks the build is not specifying a version of RVM. Either 2.6.3 or 2.6.5 is valid as long as the version installed is the same as the version required for the run. |
Thanks for the clarification! |
Description
I noticed that recently my nightly build pipeline for v1.x (drawing on the v1.x branch from the main repository as its source) began to fail. I hadn't changed any code, but I noticed that the error being generated stemmed from an RVM version issue that I fixed in master by pinning the dependency version as part of my General Version Dropdown PR. Since v1.x doesn't include changes to master, I realized that I would need to incorporate this fix in v1.x as well in order to get my nightly builds (or any website builds on this branch) to pass.
I tested my fix for this branch via my v1.x nightly build Jenkins pipeline, and it passed with my changes.
Checklist
Essentials
Changes