Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fail build_windows.py if all retries failed #18177

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Fail build_windows.py if all retries failed #18177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e67bab
Fail build_windows.py if all retries failed
leezu Apr 27, 2020
36b7610
Fix pylint with unpinned astroid causing CI issues
leezu Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ci/build_windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@ def windows_build(args):
logging.info("Build flavour: {} complete in directory: \"{}\"".format(args.flavour, os.path.abspath(path)))
logging.info("Build took {}".format(datetime.timedelta(seconds=int(time.time() - t0))))
break
windows_package(args)
if ret == 0:
windows_package(args)
else:
sys.exit(1)


def windows_package(args):
Expand Down
3 changes: 2 additions & 1 deletion ci/docker/install/requirements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ Cython==0.29.7

# Development dependencies
cpplint==1.3.0
pylint==2.3.1; python_version >= '3.0'
pylint==2.3.1 # pylint and astroid need to be aligned
astroid==2.3.3 # pylint and astroid need to be aligned
pytest==5.3.5
pytest-env==0.6.2
pytest-cov==2.8.1
Expand Down