Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Cherry-pick "Fix SoftReLU fused operator numerical stability (#17849)" #19391

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Oct 20, 2020

  • fix numerically unstable fused softrelu op

  • implement test for softrelu numerical stability

@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, windows-cpu, unix-gpu, website, centos-cpu, windows-gpu, unix-cpu, miscellaneous, clang, sanity, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 changed the title Fix SoftReLU fused operator numerical stability (#17849) [v1.x] Cherry-pick "Fix SoftReLU fused operator numerical stability (#17849)" Oct 20, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
* fix numerically unstable fused softrelu op

* implement test for softrelu numerical stability
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2020
@samskalicky samskalicky merged commit 468e21d into apache:v1.x Oct 23, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
…e#19391)

* fix numerically unstable fused softrelu op

* implement test for softrelu numerical stability

Co-authored-by: RuRo <ruro.ruro@ya.ru>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants