This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[1.x] Backport Faster pointwise fusion graph pass (#19269) #19413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Faster pointwise fusion graph pass * Fix lint * Fix lint 2 * Fixes * Fixing slice parameter handling in fusion * Fixing the slice fix * Fix the cycle bug * Added test * Fix lint * Fix merging of subgraphs * Fixes from review
Hey @ptrendx , Thanks for submitting the PR
CI supported jobs: [unix-cpu, website, windows-cpu, centos-gpu, edge, centos-cpu, sanity, clang, windows-gpu, miscellaneous, unix-gpu] Note: |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Oct 22, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Oct 23, 2020
ptrendx
changed the title
Faster pointwise fusion graph pass (#19269)
[1.x] Backport Faster pointwise fusion graph pass (#19269)
Oct 23, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Oct 23, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Oct 23, 2020
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Oct 25, 2020
DickJC123
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review the original PR. However, I'm approving this based on:
- the original PR being part of master for almost a month without issue,
- my review of the minor non-functional changes made during the backport to avoid C++17 features.
josephevans
pushed a commit
to josephevans/mxnet
that referenced
this pull request
Dec 8, 2020
…che#19413) * Faster pointwise fusion graph pass (apache#19269) * Faster pointwise fusion graph pass * Fix lint * Fix lint 2 * Fixes * Fixing slice parameter handling in fusion * Fixing the slice fix * Fix the cycle bug * Added test * Fix lint * Fix merging of subgraphs * Fixes from review * Use std::tie instead of C++17 structured binding * More fixes for lack of c++17 * Fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #19269 to v1.x branch.