Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backport Faster pointwise fusion graph pass (#19269) #19413

Merged
merged 4 commits into from
Nov 17, 2020

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Oct 22, 2020

Description

Backport of #19269 to v1.x branch.

* Faster pointwise fusion graph pass

* Fix lint

* Fix lint 2

* Fixes

* Fixing slice parameter handling in fusion

* Fixing the slice fix

* Fix the cycle bug

* Added test

* Fix lint

* Fix merging of subgraphs

* Fixes from review
@mxnet-bot
Copy link

Hey @ptrendx , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, website, windows-cpu, centos-gpu, edge, centos-cpu, sanity, clang, windows-gpu, miscellaneous, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 22, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 23, 2020
@ptrendx ptrendx changed the title Faster pointwise fusion graph pass (#19269) [1.x] Backport Faster pointwise fusion graph pass (#19269) Oct 23, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 23, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 23, 2020
@szha
Copy link
Member

szha commented Oct 25, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 25, 2020
@DickJC123 DickJC123 self-requested a review November 17, 2020 02:08
Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the original PR. However, I'm approving this based on:

  • the original PR being part of master for almost a month without issue,
  • my review of the minor non-functional changes made during the backport to avoid C++17 features.

@ptrendx ptrendx merged commit d2600f2 into apache:v1.x Nov 17, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
…che#19413)

* Faster pointwise fusion graph pass (apache#19269)

* Faster pointwise fusion graph pass

* Fix lint

* Fix lint 2

* Fixes

* Fixing slice parameter handling in fusion

* Fixing the slice fix

* Fix the cycle bug

* Added test

* Fix lint

* Fix merging of subgraphs

* Fixes from review

* Use std::tie instead of C++17 structured binding

* More fixes for lack of c++17

* Fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants