This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Save/Load Gluon Blocks & HybridBlocks #19564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [edge, clang, windows-cpu, centos-cpu, miscellaneous, sanity, unix-cpu, centos-gpu, website, unix-gpu, windows-gpu] Note: |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Nov 19, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Nov 20, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Nov 20, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Nov 20, 2020
lanking520
added
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Nov 20, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-work-in-progress
PR is still work in progress
labels
Nov 20, 2020
leezu
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Dec 12, 2020
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Dec 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
master branch version of PoC for saving & loading Gluon Blocks & HybridBlocks from #19535. Version for v1.x is #19565. This PR is fundamentally different due to the changes on the master branch for block names/UUIDs compared to v1.x
This PR adds 2 new APIs to Gluon Blocks:
save
Saves the model parameters and a json structure of the model that stores the various names/UUIDs in order to later restore and match the saved parameters. This does not actually store the model. Users still need to recreate their model architecture using their Gluon code in Python.
It also stores the hybridized Symbol objects for HybridBlocks and associated settings so that it can be later reloaded.
load
Loads the model parameters and a json structure of the model. It restores the names/UUIDs of blocks in order to match the saved parameters.
Also restores hybridized Symbol objects in HybridBlocks so they do not need to be hybridized again. After calling the
load
API users can immediately run inference without needing to hybridize.Other changes
load_json
function in Symbol namespace tofromjson
to match the correspondingtojson
API