Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[website] Fix file path in build_docs #19901

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Conversation

waytrue17
Copy link
Contributor

Description

The restricted-website-build-master pipeline is failing due to files not found issue:https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-website-build-master/activity.
By inspecting the build, the missing files blog, ecosystem and features were moved from html/ to html/pages.
This PR fix the file paths in build_docs

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, miscellaneous, windows-gpu, website, unix-cpu, unix-gpu, clang, sanity, edge, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 15, 2021
@waytrue17
Copy link
Contributor Author

@ys2843 @mseth10 Could you please review?

Copy link
Contributor

@ys2843 ys2843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 1 quick question, does it work if replacing blog ecosystem features with pages in the first for loop?

@waytrue17
Copy link
Contributor Author

waytrue17 commented Feb 16, 2021

Looks good. 1 quick question, does it work if replacing blog ecosystem features with pages in the first for loop?

I am not sure. That will change the file structure of versions/master/ from

blog
ecosystem
features
...

to

pages
----blog
----ecosystem
----features
...

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 16, 2021
@waytrue17
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Feb 16, 2021
@ys2843
Copy link
Contributor

ys2843 commented Feb 16, 2021

@waytrue17 Thanks for clarifying. It would be great if we can identify the root cause of this file location change. Is it caused by the build script change?

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 16, 2021
@leezu leezu merged commit d82d19f into apache:master Feb 16, 2021
@waytrue17 waytrue17 deleted the website branch February 17, 2021 01:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants