Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] Fix CI slowdown issue after removing 3rdparty/openmp #20367

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

bgawrych
Copy link
Contributor

Description

This PR fixes slowdown on CI (#20092) introduced after removing 3rdparty/openmp.

GOMP by default doesn't use OMP_DYNAMIC and OMP_NESTED which allows to run parallel regions inside other parallel region.
e.g.

#pragma omp parallel for
for(int i .....) {
    do_sth()...
    #pragma omp parallel for
    for(int i ....) {}
}

Even if there is "if" directive causing sequential run it's still treated as parallel region - setting OMP_DYNAMIC and OMP_NESTED somewhat helps, but seems that without "if" clause in GOMP we get even better performance and we don't need to set above env variables.

CC: @akarbown

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, centos-gpu, miscellaneous, unix-cpu, windows-cpu, clang, centos-cpu, sanity, edge, windows-gpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 21, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 21, 2021
@Zha0q1
Copy link
Contributor

Zha0q1 commented Jun 21, 2021

Thanks for the fix! Is this pr ready to merge now? Also do we know if this is the only slowdown?

Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akarbown akarbown merged commit 5dbba54 into apache:master Jun 22, 2021
@akarbown
Copy link
Contributor

@bgawrych, thanks for the fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants