If variable is not used within the loop body, start the name with an underscore

[mozga-intel]

Description

Loop control variable 'x' is not used within the loop body. If this is intended, start the name with an underscore.

Checklist

Essentials

• PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage
• Code is well-documented

Changes

• Feature1, tests, (and when applicable, API doc)
• Feature2, tests, (and when applicable, API doc)

Comments

• If this change is a backward incompatible change, why must this change be made.
• Interesting edge cases to note here

[mxnet-bot]

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

• To trigger all jobs: @mxnet-bot run ci [all]
• To trigger specific jobs: @mxnet-bot run ci [job1, job2]

---

CI supported jobs: [unix-gpu, clang, windows-cpu, unix-cpu, miscellaneous, sanity, centos-cpu, centos-gpu, windows-gpu, edge, website]

---

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

[mozga-intel]

@szha Could you help:

Please have a look at the test: test. There is an axis param that is set up in a loop: [loop] Loop control variable 'axis' not used within the loop body but it's only used out of the loop scope: loop

    for axis in range(-data_ndim, data_ndim):
        data_shape = ()
        for _ in range(data_ndim):
            data_shape += (np.random.randint(low=1, high=5), )
        idx_shape = ()
        for _ in range(idx_ndim):
            idx_shape += (np.random.randint(low=1, high=5), )
     ....
    
    result = mx.sym.take(a=data, indices=idx, axis=axis, mode=mode)

The axis is always equal to data_ndim- 1. Following the documentation doc, the axis of an input array is to be taken. For the input tensor of rank r, it could be in the range of [-r, r-1]. Where r = data_ndim; There is a similar issue: #20508 (Float32 Linlag Cholesky is disabled by default)

Could you please tell whether the lines L4191 to L4231 shouldn't be placed in the loop scope to get a changeable axis?

[mozga-intel]

@mxnet-bot run ci [website]

[mxnet-bot]

Jenkins CI successfully triggered : [website]

[mozga-intel]

@mxnet-bot run ci [centos-gpu]

[mozga-intel]

@mxnet-bot run ci [centos-gpu, unix-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [unix-gpu, centos-gpu]

[szha]

Thanks for the fix. A few loops can be updated to be more clear.