[master][bugfix] Remove exit 0 to avoid blocking in CI pipeline

[mozga-intel]

Description

Exit 0, returns 'true' and then the CI is stopped; the 0 cannot be returned.

Checklist

Essentials

• PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage
• Code is well-documented

Changes

• Feature1, tests, (and when applicable, API doc)
• Feature2, tests, (and when applicable, API doc)

Comments

• If this change is a backward incompatible change, why must this change be made.
• Interesting edge cases to note here

[mxnet-bot]

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

• To trigger all jobs: @mxnet-bot run ci [all]
• To trigger specific jobs: @mxnet-bot run ci [job1, job2]

---

CI supported jobs: [windows-gpu, windows-cpu, centos-cpu, clang, centos-gpu, unix-gpu, unix-cpu, sanity, miscellaneous, website, edge]

---

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

[marcoabreu]

I'm not sure I can follow you.

Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?

[marcoabreu]

This is disabling clang-format.

[mozga-intel]

I'm not sure I can follow you.

Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?

@marcoabreu ; Thanks for the question!
From man bash on return [n]

Exit 0 means continue, non-zero means abort. To me it seems like you're rather disabling CI rather than fixing the issue clang is revealing and thus aborting... Or is this called in a chain of commands?

on exit [n]

Cause the shell to exit with a status of n. If n is omitted, the exit status is that of the last command executed. A trap on EXIT is executed before the shell terminates.

Finally, functions, when called, the exit 0 (within the function) exits a code ~ without a failure. The return has nothing to do with exit codes.

[mozga-intel]

@mxnet-bot run ci [centos-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [centos-gpu]

[mozga-intel]

@mxnet-bot run ci [centos-gpu]

[mxnet-bot]

Jenkins CI successfully triggered : [centos-gpu]

[mozga-intel]

@szha Could you please help with a merge? Thanks!

[szha]

thanks for the fix!