Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[FEATURE] Add quantized version of reshape with DNNL reorder primitive. #20835

Merged
merged 8 commits into from
Feb 16, 2022
Merged

[FEATURE] Add quantized version of reshape with DNNL reorder primitive. #20835

merged 8 commits into from
Feb 16, 2022

Conversation

agrabows
Copy link
Contributor

@agrabows agrabows commented Jan 20, 2022 •
edited
Loading

Description

Reshape operators from both NDArray and NumPy modules of MXNet had no quantized version so if it appeared between two quantized operators data would have to be dequantized and quantized again after reshape (as shown on picture below with version after change as well). Goal was to create quantized reshape operator.
Previous version:
image
New version:
image
Speedup:
image

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage

Changes

  • Add quantized version of numpy/numpy_extension reshape
  • Add quantized version of ndarray reshape

@mxnet-bot
Copy link

Hey @agrabows , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-gpu, clang, centos-cpu, unix-gpu, website, windows-cpu, windows-gpu, unix-cpu, edge, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 20, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 20, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 20, 2022
@agrabows agrabows requested a review from szha as a code owner January 26, 2022 17:10
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 26, 2022
RafLit
RafLit reviewed Jan 31, 2022
View reviewed changes
src/operator/quantization/quantized_reshape-inl.h Outdated Show resolved Hide resolved
src/operator/quantization/quantized_reshape-inl.h Outdated Show resolved Hide resolved
src/operator/quantization/quantized_reshape.cc Outdated Show resolved Hide resolved
tests/python/quantization/test_quantization.py Outdated Show resolved Hide resolved
tests/python/dnnl/subgraphs/test_conv_subgraph.py Outdated Show resolved Hide resolved
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Feb 4, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 9, 2022
@agrabows
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 10, 2022
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 15, 2022
bartekkuncer
bartekkuncer approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 15, 2022
@bgawrych bgawrych merged commit f35a4d7 into apache:master Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RafLit RafLit RafLit approved these changes

@bgawrych bgawrych bgawrych approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@agrabows @mxnet-bot @RafLit @bgawrych @bartekkuncer @mseth10 @agrabow