Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix link error for parallel rng #9256

Merged
merged 1 commit into from
Dec 30, 2017
Merged

fix link error for parallel rng #9256

merged 1 commit into from
Dec 30, 2017

Conversation

yzhliu
Copy link
Member

@yzhliu yzhliu commented Dec 30, 2017

Description

Fix #9229

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Fix link error

@yzhliu yzhliu merged commit 4c15f58 into apache:master Dec 30, 2017
yzhliu added a commit to yzhliu/mxnet that referenced this pull request Dec 30, 2017
@yzhliu
fix link error for parallel rng (apache#9256)
ecf4c9f
@yzhliu yzhliu mentioned this pull request Dec 30, 2017
Closed
szha
szha reviewed Dec 30, 2017
View reviewed changes
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

piiswrong
piiswrong reviewed Dec 31, 2017
View reviewed changes
src/common/random_generator.h
@@ -47,9 +47,9 @@ template<typename DType>
class RandGenerator<cpu, DType> {
public:
// at least how many random numbers should be generated by one CPU thread.
static const int kMinNumRandomPerThread = 64;
static const int kMinNumRandomPerThread;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constexpr so that you don't need to define it separately

meissnereric pushed a commit to meissnereric/incubator-mxnet that referenced this pull request Jan 2, 2018
@yzhliu @meissnereric
fix link error for parallel rng (apache#9256)
93ab55a
yuxiangw pushed a commit to yuxiangw/incubator-mxnet that referenced this pull request Jan 25, 2018
@yzhliu @yuxiangw
fix link error for parallel rng (apache#9256)
0d48485
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@yzhliu
fix link error for parallel rng (apache#9256)
d1a7baa
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@yzhliu @zheng-da
fix link error for parallel rng (apache#9256)
9f050bc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha szha left review comments

@piiswrong piiswrong piiswrong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building from scratch on macOS 10.13.2 error 1
3 participants
@yzhliu @piiswrong @szha