Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Text API (Resubmit #8763 #9394) #9406

Merged
merged 1 commit into from
Jan 13, 2018
Merged

Text API (Resubmit #8763 #9394) #9406

merged 1 commit into from
Jan 13, 2018

Conversation

szha
Copy link
Member

@szha szha commented Jan 12, 2018

Description

This is resubmission of #8763 #9394 @astonzhang

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes


@classmethod
def _get_pretrained_file(cls, embedding_root, pretrained_file_name):
from ...gluon.utils import check_sha1, download
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one minor additional change to avoid changing the mxnet import chain in __init__

@szha szha force-pushed the text_fix branch 4 times, most recently from 8635899 to 17a9343 Compare January 12, 2018 21:19
from .embedding import TokenEmbedding


class Glossary(TokenEmbedding):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is more commonly called Vocabulary

@piiswrong
Copy link
Contributor

I'll do a pass some time soon. API naming and interfaces need to be changed.
@astonzhang would you like to do the resubmission or would you like @szha to handle it?

@szha
Copy link
Member Author

szha commented Jan 13, 2018

@piiswrong I submitted this PR for respecting your request to move the text API to contrib. Given that the original PR has spanned a month, and you commented on it, I was under the impression that you had plenty of time to provide feedback on it. That said, let's address your concerns step-by-step.

Since @astonzhang has iterated with me on this over quite some time in #8763, there would be lots of context to help explain the motivation behind the design, on which Aston and I are happy to fill you in.

Then, if you still think that API changes need to be done, I agree with @mli that if you would propose the desired changes through an email thread on dev-list, issues, or through a new PR proposal, it would be much preferred. Besides, I look forward to learning the more desirable design from you. Thank you very much.

@piiswrong piiswrong merged commit e4957c3 into apache:master Jan 13, 2018
@szha szha deleted the text_fix branch January 13, 2018 22:16
CodingCat pushed a commit to CodingCat/mxnet that referenced this pull request Jan 16, 2018
yuxiangw pushed a commit to yuxiangw/incubator-mxnet that referenced this pull request Jan 25, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants