Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.apache.org/jira/browse/MYFACES-4679: #744

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

werpu
Copy link
Contributor

@werpu werpu commented Sep 1, 2024

Fixes for issue

@werpu
Copy link
Contributor Author

werpu commented Sep 1, 2024

This should fix the issue from the js side. The main culprit was that behavior events added the key value pair from the issuing element (4606 patch), and then on the server side an action was triggered automatically

@volosied @tandraschko please test this patch, for me this restores the wanted original behavior!
I guess @tandraschko your merge request now can be dropped if this works well!

@werpu werpu assigned volosied and unassigned melloware Sep 1, 2024
@volosied
Copy link
Contributor

volosied commented Sep 1, 2024

Thanks for the fix, but I don't think this handles the original scenario in 4606 --

The original test would send the jakarta.faces.behavior.event "click" as part of the request, and this fix would avoid appending it to the request.

Edit: I followed up with email to the faces community.

@volosied
Copy link
Contributor

volosied commented Sep 1, 2024

Part of me is worried about handing this from the JavaScript side as it would affect all requests while with a Java fix, we would only handle the commandButton behavior.

@werpu werpu mentioned this pull request Sep 2, 2024
@werpu werpu merged commit b062baf into apache:main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants