hw/mcu: Fix compilation with ARM GCC 13

multiple hal_timer_stop() implementations follow same pattern which seems to trigger false-positive (ie entry cannot be used uninitialized here) with ARM GCC 13.2 Compiling repos/apache-mynewt-core/kernel/os/src/os_error.c Error: repos/apache-mynewt-core/hw/mcu/nordic/nrf5340/src/hal_timer.c: In function 'hal_timer_stop': repos/apache-mynewt-core/hw/mcu/nordic/nrf5340/src/hal_timer.c:885:17: error: 'entry' may be used uninitialized [-Werror=maybe-uninitialized] 885 | nrf_timer_set_ocmp((struct nrf5340_hal_timer *) entry->bsp_timer, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 886 | entry->expiry); | ~~~~~~~~~~~~~~ repos/apache-mynewt-core/hw/mcu/nordic/nrf5340/src/hal_timer.c:863:23: note: 'entry' was declared here 863 | struct hal_timer *entry;
apache · Oct 6, 2023 · 25cd4af · 25cd4af
1 parent b78d14a
commit 25cd4af
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/hw/mcu/native/src/hal_timer.c b/hw/mcu/native/src/hal_timer.c
@@ -331,7 +331,7 @@ int
 hal_timer_stop(struct hal_timer *timer)
 {
     struct native_timer *nt;
-    struct hal_timer *ht;
+    struct hal_timer *ht = NULL;
     int reset_ocmp;
     os_sr_t sr;
 

diff --git a/hw/mcu/nordic/nrf51xxx/src/hal_timer.c b/hw/mcu/nordic/nrf51xxx/src/hal_timer.c
@@ -939,7 +939,7 @@ hal_timer_stop(struct hal_timer *timer)
 {
     uint32_t ctx;
     int reset_ocmp;
-    struct hal_timer *entry;
+    struct hal_timer *entry = NULL;
     struct nrf51_hal_timer *bsptimer;
 
     if (timer == NULL) {

diff --git a/hw/mcu/nordic/nrf52xxx/src/hal_timer.c b/hw/mcu/nordic/nrf52xxx/src/hal_timer.c
@@ -908,7 +908,7 @@ hal_timer_stop(struct hal_timer *timer)
 {
     uint32_t ctx;
     int reset_ocmp;
-    struct hal_timer *entry;
+    struct hal_timer *entry = NULL;
     struct nrf52_hal_timer *bsptimer;
 
     if (timer == NULL) {

diff --git a/hw/mcu/nordic/nrf5340/src/hal_timer.c b/hw/mcu/nordic/nrf5340/src/hal_timer.c
@@ -860,7 +860,7 @@ hal_timer_stop(struct hal_timer *timer)
 {
     uint32_t ctx;
     int reset_ocmp;
-    struct hal_timer *entry;
+    struct hal_timer *entry = NULL;
     struct nrf5340_hal_timer *bsptimer;
 
     if (timer == NULL) {

diff --git a/hw/mcu/nordic/nrf5340_net/src/hal_timer.c b/hw/mcu/nordic/nrf5340_net/src/hal_timer.c
@@ -860,7 +860,7 @@ hal_timer_stop(struct hal_timer *timer)
 {
     uint32_t ctx;
     int reset_ocmp;
-    struct hal_timer *entry;
+    struct hal_timer *entry = NULL;
     struct nrf5340_hal_timer *bsptimer;
 
     if (timer == NULL) {

diff --git a/hw/mcu/nordic/nrf91xx/src/hal_timer.c b/hw/mcu/nordic/nrf91xx/src/hal_timer.c
@@ -894,7 +894,7 @@ hal_timer_stop(struct hal_timer *timer)
 {
     uint32_t ctx;
     int reset_ocmp;
-    struct hal_timer *entry;
+    struct hal_timer *entry = NULL;
     struct nrf91_hal_timer *bsptimer;
 
     if (timer == NULL) {

diff --git a/hw/mcu/nxp/kinetis/src/hal_timer.c b/hw/mcu/nxp/kinetis/src/hal_timer.c
@@ -405,7 +405,7 @@ int
 hal_timer_stop(struct hal_timer *timer)
 {
     struct kinetis_hal_tmr *tmr;
-    struct hal_timer *entry;
+    struct hal_timer *entry = NULL;
     bool reset_period;
     os_sr_t sr;
 

diff --git a/hw/mcu/stm/stm32_common/src/hal_timer.c b/hw/mcu/stm/stm32_common/src/hal_timer.c
@@ -784,7 +784,7 @@ int
 hal_timer_stop(struct hal_timer *timer)
 {
     struct stm32_hal_tmr *tmr;
-    struct hal_timer *ht;
+    struct hal_timer *ht = NULL;
     int sr;
     int reset_ocmp;