tinyusb/dfu: Fix build when auto confirm is off #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the code and data was included only if USBD_DFU_RESET_AFTER_DOWNLOAD was set. While package init function used those functions and data regardless of syscfg value. package init function is not called from sysinit when USBD_DFU_RESET_AFTER_DOWNLOAD is not set but code inside is still there. Now all code is there and if functionality is not used package init function will not be called from sysinit.
sjanc
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the code and data was included only if
USBD_DFU_RESET_AFTER_DOWNLOAD was set.
While package init function used those functions and data regardless of syscfg value.
package init function is not called from sysinit when USBD_DFU_RESET_AFTER_DOWNLOAD is not set but code inside is still there.
Now all code is there and if functionality is not used package init function will not be called from sysinit.