Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] On text/x-properties Comment/Uncomment buttons not showing #7207

Closed
cesarreyes3 opened this issue Mar 28, 2024 · 6 comments · Fixed by #7223
Closed

[bug] On text/x-properties Comment/Uncomment buttons not showing #7207

cesarreyes3 opened this issue Mar 28, 2024 · 6 comments · Fixed by #7223
Assignees
Labels
Contribution welcome An issue or feature not currently being worked on, but a contribution would be welcomed! kind:bug Bug report or fix

Comments

@cesarreyes3
Copy link

Apache NetBeans version

Apache NetBeans 21

What happened

On text/x-properties Comment/Uncomment buttons not showing

Apparently the necessary code exists, but it is not working

protected Action[] createActions() {
Action[] actions = new Action[] {
new ToggleCommentAction("#"), //NOI18N
};
return TextAction.augmentList(super.createActions(), actions);
}

public static final String PROPERTIES_MIME_TYPE = "text/x-properties"; // NOI18N

Language / Project Type / NetBeans Component

No response

How to reproduce

Just open an .properties file, no Comment/Uncommet buttons

Did this work correctly in an earlier version?

No / Don't know

Operating System

Windows 10

JDK

12

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

No response

Are you willing to submit a pull request?

No

@cesarreyes3 cesarreyes3 added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Mar 28, 2024
@mbien mbien added Contribution welcome An issue or feature not currently being worked on, but a contribution would be welcomed! and removed needs:triage Requires attention from one of the committers labels Mar 30, 2024
matthiasblaesing added a commit to matthiasblaesing/netbeans that referenced this issue Apr 1, 2024
@matthiasblaesing
Copy link
Contributor

@cesarreyes3 please test the nightly build available from the checks page of #7223 ("Artifacts" dropdown at the top of https://github.com/apache/netbeans/pull/7223/checks or directly https://github.com/apache/netbeans/suites/22309102380/artifacts/1375202417)

@matthiasblaesing matthiasblaesing self-assigned this Apr 2, 2024
@cesarreyes3
Copy link
Author

cesarreyes3 commented Apr 4, 2024

Sorry, I'm on Windows and I don't know how to test that build,
I tried to replace the org-netbeans-modules-properties-syntax.jar and org-netbeans-modules-xml-tools.jar .jars,
but i didn't get any result

Maybe replacing the jars was not the right choose, but since only thosefiles were edited I thought it would work

@matthiasblaesing
Copy link
Contributor

  1. Unzip the build
  2. Find the bin directory
  3. Run NetBeans using the netbeans64.exe launcher

The nightly builds use their own cache and user directory, so testing should be clean. Please do not import settings from old versions.

After testing please ensure, that to remove the cache and user dir again (use Help -> About to find the paths).

@cesarreyes3
Copy link
Author

I tried to replace the org-netbeans-modules-properties-syntax.jar and org-netbeans-modules-xml-tools.jar jars,

The nightly build was not necessary, i just remove netbeans cache, now works on my instalation, thanks

@cesarreyes3
Copy link
Author

On this part, porperties has a highlight bug(i did write it twice to show the problem)

Netbeans

image

Github

[new_oids]

[ new_oids ]

# We can add new OIDs in here
tsa_policy1 = 1.2.3.4.1

@matthiasblaesing
Copy link
Contributor

@cesarreyes3 Two things:

  1. What is your point? Property files have no sections, so first line a key without value, the second line is the key "[" with the value "new_oids ]".
  2. Please don't reuse issues

I reopen this issue, as it will be automatically closed once the fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution welcome An issue or feature not currently being worked on, but a contribution would be welcomed! kind:bug Bug report or fix
Projects
None yet
3 participants