Native Execution Binaries workflow and changes for macOS Arm. #6513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilcsmith-net
force-pushed
the
nativeexec-workflow
branch
from
4d1e9a0
to
778ea04
Compare
3 tasks
mbien
reviewed
Oct 2, 2023
.github/workflows/native-binary-build-dlight.nativeexecution.yml
Outdated
Show resolved
Hide resolved
vieiro
approved these changes
Oct 2, 2023
neilcsmith-net
force-pushed
the
nativeexec-workflow
branch
from
778ea04
to
c525351
Compare
|
Thanks! Remaining profiler reference removed. Once green again, I'll merge, trigger and stage the binaries. Then I'll open a draft PR to include the Apple Silicon support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a GitHub workflow to build the
dlight.nativeexecutionbinaries, and include fixes to allow building for Apple Silicon (with thanks to @tmulle and @oyarzun for input on #3467 )This workflow is based on the changes to the profiler workflow, first building a source bundle suitable for a release vote, then using that to build the binaries.
Cross compilation on macOS required moving to a new build script and manually specifying the OS and CPU architecture.
This currently builds for Linux x64_86, and macOS x86_64 and arm64. Building for Windows is left for a later stage. For NB20 we should probably look to just include just those Apple Silicon libraries we can and leave the existing libs. I've tested terminal support, but not any other uses of these libraries.