Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot of APIs as of NetBeans 21 #6960

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

neilcsmith-net
Copy link
Member

@neilcsmith-net neilcsmith-net commented Jan 16, 2024

Snapshot of APIs as of NetBeans 21. For review purposes only at this stage. Not to be merged as / until release vote completes and updated if necessary.

Built in the usual way ...
# checkout branch (or release tag)
git checkout release210
git clean -dxf
ant build
ant gen-sigtests-release
git add -A
git stash
git checkout master
git checkout -b apis-nb210
git stash pop
git add -A
git commit -m "Snapshot of APIs as of NetBeans 21"
# remove getPeer() calls
find . -name "*.sig" -exec sed -i '/java.awt.peer.ComponentPeer/{N;d;}' {} \;
# check git diff
git add -A
git commit --amend

Filtered diff created using -

curl -L https://github.com/apache/netbeans/pull/<PR_ID>.diff | filterdiff -#2- > filtered-apis-nb210.txt

Filtered diff : filtered-apis-nb210.txt

@neilcsmith-net neilcsmith-net added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes. labels Jan 16, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good I think

@ebarboni
Copy link
Contributor

as I see a lot of php related changes I add @junichi11.

LGTM

Copy link
Member

@junichi11 junichi11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilcsmith-net
Copy link
Member Author

@ebarboni @mbien updated this as Gradle changes brought in some additions. Then rebased on current master because of a conflict. Hopefully correct now - more eyes appreciated! 👀

@neilcsmith-net neilcsmith-net removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Feb 20, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i diffed the diff files of 5e5e614, de78725 and 6b7e3a9 and changes looked good

@mbien
Copy link
Member

mbien commented Feb 21, 2024

can I merge this?

@neilcsmith-net
Copy link
Member Author

Please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release process PRs (eg. versions, sync) that are part of the release process and can be ignored in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants