Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade commons libs, freemarker, jackson, guava, gson, maven-indexer, junit and jgit #7569

Merged
merged 12 commits into from
Jul 16, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Jul 13, 2024

  • Update jgit from 9.9.0 to 9.10.0
  • Update bouncycastle from 1.77 to 1.78.1
  • Update maven indexer to 7.1.4 and lucene to 9.11.1
  • Update gson from 2.8.9 to 2.11.0
  • Update guava from 33.0.0 to 33.2.1
  • Update Jackson from 2.17.0 to 2.17.2
  • Update JUnit from 5.10.2 to 5.10.3
  • Update Freemarker from 2.3.32 to 2.3.33
  • Update commons-logging from 1.3.1 to 1.3.3
  • Update commons-io from 2.16.0 to 2.16.1
  • Update commons-codec from 1.16.1 to 1.17.0
  • Update commons-net from 3.10.0 to 3.11.1
  • Update commons-compress from 1.26.1 to 1.26.2

NB can't load bouncycastle 1.78.1:

    [junit] WARNING [org.netbeans.core.netigso.Netigso]: Cannot fake bcprov
    [junit] org.osgi.framework.BundleException: Invalid manifest header Import-Package: "java.io;resolution:="optional"" : Cannot specify java.* packages in Import/Export headers "java.io"
    [junit] 	at org.eclipse.osgi.internal.resolver.StateBuilder.checkImportExportSyntax(StateBuilder.java:824)
    [junit] 	at org.eclipse.osgi.internal.resolver.StateBuilder.validateHeaders(StateBuilder.java:212)
...

@mbien mbien added do not merge Don't merge this PR, it is not ready or just demonstration purposes. Upgrade Library Library (Dependency) Upgrade ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 13, 2024
@mbien mbien added this to the NB23 milestone Jul 13, 2024
@mbien
Copy link
Member Author

mbien commented Jul 13, 2024

smoke tests:

  • create, run, debug test "hello world" ant, maven, gradle projects
  • git init, commit, history
  • maven indexing, SMO, some dependency usecases (dl source, view javadoc in via NB embedded webserver )
  • JDK download via disco API
  • open larger projects and check if everything works as expected

found minor problems (e.g #7570, #7571, #7572) but no regressions to NB 22 so far

@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Jul 13, 2024
@mbien mbien marked this pull request as ready for review July 13, 2024 21:25
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane to me. The updated libraries don't trigger bad vibes and at least a quick test did not show problems. Thanks.

@mbien mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jul 15, 2024
@mbien
Copy link
Member Author

mbien commented Jul 15, 2024

going to rebase and merge if tests are green, thanks for review

@mbien mbien merged commit 34d371d into apache:master Jul 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants