Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MavenVersionSettings: Stick to maven 3 plugins for now #7574

Merged
merged 1 commit into from
Jul 14, 2024
Merged

MavenVersionSettings: Stick to maven 3 plugins for now #7574

merged 1 commit into from
Jul 14, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Jul 13, 2024 •
edited
Loading

  • NB wizards and similar features should not blindly upgrade to mvn4 core plugins
  • also bumps version fallback of surefire/failsafe to 3.3.1

fixes #7571

example how to test:

  • your local repo must contain maven-compiler-plugin v 4.0.0-beta-1
  • create maven project, make sure nb scanned your local repo
  • open project properties -> compiler, enable -Xlint, this will insert the compiler plugin into the pom
  • version should not exceed 3.x

@mbien
MavenVersionSettings: Stick to maven 3 plugins for now
6ea612d 
 - NB wizards and similar features should not blindly upgrade to mvn4
   core plugins
 - also bumps version fallback of surefire/failsafe to 3.3.1
@mbien mbien added Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 13, 2024
@mbien mbien added this to the NB23 milestone Jul 13, 2024
matthiasblaesing
matthiasblaesing approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach makes sense to me and good seems trivially correct. Thanks.

@mbien mbien merged commit 6d5b4c8 into apache:master Jul 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@neilcsmith-net neilcsmith-net Awaiting requested review from neilcsmith-net

@sdedic sdedic Awaiting requested review from sdedic

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

Internal utilities for maven plugin core dependency updates should stick to 3.x version for now
2 participants
@mbien @matthiasblaesing