-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-2185 Upgrade to Visual Studio 2022 #1635
Closed
fgerlits
wants to merge
3
commits into
apache:main
from
fgerlits:MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
Closed
MINIFICPP-2185 Upgrade to Visual Studio 2022 #1635
fgerlits
wants to merge
3
commits into
apache:main
from
fgerlits:MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
reviewed
Aug 21, 2023
fgerlits
force-pushed
the
MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
branch
from
August 22, 2023 15:16
ca4799c
to
f222b0f
Compare
lordgamez
approved these changes
Aug 23, 2023
adamdebreceni
approved these changes
Aug 28, 2023
martinzink
approved these changes
Aug 29, 2023
The string <-> wstring conversion functions in #1634 are better, so we should merge that PR first, and then I will merge those changes with this PR. |
fgerlits
force-pushed
the
MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
branch
2 times, most recently
from
September 25, 2023 10:14
2c28fa4
to
4e95ec6
Compare
lordgamez
reviewed
Sep 26, 2023
adamdebreceni
approved these changes
Sep 26, 2023
lordgamez
approved these changes
Sep 26, 2023
fgerlits
force-pushed
the
MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
branch
from
October 4, 2023 08:36
8a32045
to
29a58eb
Compare
fgerlits
force-pushed
the
MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
branch
from
October 4, 2023 08:53
29a58eb
to
36540b3
Compare
szaszm
reviewed
Oct 4, 2023
fgerlits
force-pushed
the
MINIFICPP-2185_Upgrade-to-Visual-Studio-2022
branch
from
October 4, 2023 13:50
983890d
to
f43de46
Compare
szaszm
approved these changes
Oct 5, 2023
martinzink
approved these changes
Oct 5, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real problem was
FileSystemRepositoryTests
, which relied on this STL bug: microsoft/STL#1511In addition to that, I have
/MP
to the command line -- I'm not sure if this does anything, but maybe;-fPIC
from the command line, as it has no meaning on Windows;UnicodeConversion.h
, and moved it fromextensions/windows-event-log
tolibminifi/utils
.For now, I have kept the VS2019 CI job and added a new VS2022 job. After MINIFICPP-2186, we can remove the VS2019 job.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.