Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13664 allow bundle id to be searchable #9197

Closed
wants to merge 1 commit into from

Conversation

mosermw
Copy link
Member

@mosermw mosermw commented Aug 23, 2024

Summary

NIFI-13664

Improved the component Search capability by allowing user to type all or part of a Bundle ID (NAR name) to find matching components. Updated the User Guide.

For example, if you type "nifi-slack" in the Search Bar, it will show "Bundle: nifi-slack-nar" from matching components.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • [n/a] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [n/a] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mosermw, the additional search capability looks good! +1 merging

@mosermw
Copy link
Member Author

mosermw commented Sep 3, 2024

Thanks for the review @exceptionfactory. May I cherry-pick this into the support/nifi-1.x branch if it merges cleanly?

@exceptionfactory
Copy link
Contributor

Thanks for the review @exceptionfactory. May I cherry-pick this into the support/nifi-1.x branch if it merges cleanly?

You're welcome @mosermw. This commit will not apply to the support branch because the Spring Configuration is now Java-based instead of XML-based, so adding it to the support branch would require a separate PR.

@mosermw
Copy link
Member Author

mosermw commented Sep 3, 2024

Thanks for the review @exceptionfactory. May I cherry-pick this into the support/nifi-1.x branch if it merges cleanly?

You're welcome @mosermw. This commit will not apply to the support branch because the Spring Configuration is now Java-based instead of XML-based, so adding it to the support branch would require a separate PR.

Ah, right! The nifi-framework-bundle moved, too. At this point, I don't think a separate PR is worth it.

@mosermw mosermw deleted the NIFI-13664 branch October 17, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants