Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13706 Handle Exceptions Fetching Parameters on Startup #9227

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

exceptionfactory
Copy link
Contributor

Summary

NIFI-13706 Updates the flow synchronization process to catch exceptions when fetching Parameters from Parameter Providers.

The framework logs a warning when catching exceptions from a Parameter Provider, and already handles logging warnings when a Parameter Provider does not return values for a configured Parameter.

This change in the startup process allows NiFi to start even when a Parameter Provider has configuration or connectivity issues. Missing Parameter values may result in flow configuration problems, which an authorized user can correct after fixing the referenced Parameter Provider.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good and verified the behavior, this is helpful for allowing NiFi to continue to start even when failing to fetch parameters, thanks!

@exceptionfactory exceptionfactory merged commit 0510e71 into apache:main Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants