NIFI-13762 Expose processor metrics as a part of FlowInfo #9281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferencerdei
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Thanks for the contribution, the approach looks good. The only thing I would modify is to make this information optional in the heartbeat. It can be turned on by default but it'd be good to make it possible to turn it off if the user doesn't need this extra info.
briansolo1985
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Thanks @pkedvessy for this improvement. The approach and the implementation looks good to me, only added two cosmetic related comments. I think we should apply the renaming, the other comment is less important
c2/c2-protocol/c2-protocol-api/src/main/java/org/apache/nifi/c2/protocol/api/FlowInfo.java
Outdated
Show resolved
Hide resolved
...ework/minifi-framework-core/src/main/java/org/apache/nifi/minifi/c2/C2NifiClientService.java
Outdated
Show resolved
Hide resolved
pkedvessy
force-pushed
the
NIFI-13762
branch
from
d5b3b82
to
cbab379
Compare
|
@briansolo1985 @ferencerdei Thanks for your reviews. I have addressed your comments. |
ferencerdei
approved these changes
Sep 24, 2024
|
thanks for the changes. going to proceed with the merge |
briansolo1985
approved these changes
Sep 24, 2024
ravinarayansingh
pushed a commit
to ravinarayansingh/nifi
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Ferenc Kis <briansolo1985@gmail.com> This closes apache#9281.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13762
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation