Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13951: Add warn policy to dropdown selection #9478

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sardell
Copy link
Contributor

@sardell sardell commented Oct 31, 2024

Summary

NIFI-13951

In addition to adding the missing Warn policy level as an option to the enforcement policy select, the default selection is no longer hard coded as Enforce but instead reads the value returned from the backend.

cc @pvillard31

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the fix and everything looks good to me with different rules. I'll let someone more familiar with the UI confirm that code is OK. As far as I'm concerned, I'm a +1. Thanks for the fix @sardell !

@mcgilman mcgilman added the new ui Pull requests for work relating to the new user interface being developed. label Nov 1, 2024
exceptionfactory

This comment was marked as outdated.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @sardell, I'm retracting my negative vote after a closer review. I was focused on the enforcement policy references for component validation, missing the visibility in the status section. I defer to others on frontend review.

Copy link
Contributor

@scottyaslan scottyaslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to create a rule and configure it to WARN.

@scottyaslan scottyaslan merged commit 78b68f6 into apache:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants