Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-13961 Allow camelCase search when filtering on component selection in UI #9481

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented Nov 2, 2024

Summary

NIFI-13961

This is my first contribution to the UI code, which is why I was quite unsure where to put these additions.
I'd appreciate any feedback. Please let me know, if I should re-arrange the structure of functions added.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins EndzeitBegins marked this pull request as draft November 2, 2024 13:29
@EndzeitBegins EndzeitBegins marked this pull request as ready for review November 2, 2024 13:50
@ChrisSamo632 ChrisSamo632 added the new ui Pull requests for work relating to the new user interface being developed. label Nov 3, 2024
@mcgilman
Copy link
Contributor

mcgilman commented Nov 6, 2024

Will review...

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @EndzeitBegins! Looks great!

@mcgilman mcgilman merged commit eb7c618 into apache:main Nov 6, 2024
5 checks passed
@EndzeitBegins EndzeitBegins deleted the NIFI-13961 branch November 6, 2024 16:18
@EndzeitBegins
Copy link
Contributor Author

Thank you for the quick review & merge @mcgilman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants