Skip to content

Commit

Permalink
Fixed: PDF-Check: Just delete unsafe PDF files (OFBIZ-13190)
Browse files Browse the repository at this point in the history
At first I planned to change the implementation to just delete the PDF file
within isValidPdfFile if the PDF's safeState is false. Then I found out that the
file deletion already happens withn isValidFile (deleteBadFile) -
hence there is no need to delete the invalid file within the PDF check itself.

Thanks: Sixty One
  • Loading branch information
JacquesLeRoux committed Dec 6, 2024
1 parent 222d889 commit 4ec432a
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,6 @@ private static boolean isValidPdfFile(String fileName) {
+ "For security reason it's not accepted as a such file",
MODULE);
}
file = new File(fileName);
file.delete();
return safeState;
}

Expand Down

0 comments on commit 4ec432a

Please sign in to comment.