Skip to content

Commit

Permalink
Fixed: jsTree visual glitch on link hover (OFBIZ-13174 - #856)
Browse files Browse the repository at this point in the history
Helveticus introduced a global CSS transition effect,
which caused various problems across the app (all the
elements that changed dimensions were animated).
jsTree plugins is concerned, when hovering links in
a tree.

This PR removes the global transition effect, and put
it on identified elements that need it (buttons and links).
  • Loading branch information
florianMo authored Nov 14, 2024
1 parent 22942db commit f03b675
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions themes/helveticus/webapp/helveticus/helveticus-main-theme.less
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
@home-menu-tile-min-width: 100px;
@home-menu-tile-max-width: 100px;

@transition: all .2s;

@import url('https://fonts.googleapis.com/css2?family=Quicksand:wght@300;400;500;600;700&display=swap');
* {
margin: 0;
Expand Down Expand Up @@ -110,7 +112,6 @@ span.label {
/*** BUTTON /LINK / NAV STYLES ***/
a, a:hover, input.buttontext, input[type="submit"] {
text-decoration: none;
transition: .2s;
}

a {
Expand All @@ -131,6 +132,7 @@ input[type="submit"], .smallSubmit, button {
padding: 0.5rem 0.8rem;
font-size: 1.2rem;
cursor: pointer;
transition: @transition;

&:hover {
color: @main-color-theme;
Expand Down Expand Up @@ -246,6 +248,7 @@ input[type="submit"], .smallSubmit, button {
color: @dark-color-theme;
font-weight: 600;
font-size: 1.2rem;
transition: @transition;
}

&.selected a, &:hover a {
Expand Down Expand Up @@ -308,8 +311,8 @@ a.buttontext {
border-radius: 0.5rem;
display: inline-block;
font-weight: 600;
margin: 0.3rem;
margin-right: 0.5rem;
margin: 0.3rem 0.5rem 0.3rem 0.3rem;
transition: @transition;

&:hover {
color: @light-color-theme;
Expand Down Expand Up @@ -563,6 +566,7 @@ a.buttontext {
font-weight: 600;
font-size: 1.2rem;
display: block;
transition: @transition;
}
}
}
Expand Down Expand Up @@ -1083,13 +1087,13 @@ label.has-checkbox, .has-radio {
padding-left: 4px;
padding-right: 5px;
border-radius: 8px 8px 8px 8px;
transition: all .2s;
transition: @transition;
}

[type="checkbox"]:checked.nrd-chkbox + label:after {
position: relative;
left: -15px;
transition: all .2s;
transition: @transition;
}

/*** TABLE STYLE ***/
Expand Down

0 comments on commit f03b675

Please sign in to comment.