refactor: some code in GitHub Actions (#1269)

* fix: typo for rocksdb comments * fix: some actions use services * fix: name in ipfs yml, install librocksdb-dev first * fix: permission and command * fix: ci test * fix: back to ipfs * fix: do not use default for rocksdb * fix: do not run bench for fork repo
apache · Feb 3, 2023 · c99e08b · c99e08b · github-actions · Feb 3, 2023
1 parent ee47d96
commit c99e08b
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 13 deletions.
diff --git a/.github/workflows/bench.yaml b/.github/workflows/bench.yaml
@@ -23,6 +23,7 @@ jobs:
           OPENDAL_FS_ROOT: /tmp/opendal/
 
       - name: Store benchmark result
+        if: github.repository_owner == 'datafuselabs'
         uses: benchmark-action/github-action-benchmark@v1
         with:
           name: Rust Benchmark

diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml
@@ -36,7 +36,7 @@ jobs:
           cp -r ./target/doc/* ./target/book
 
       - name: Deploy to vercel
-        if: github.ref_name == 'main'
+        if: github.repository_owner == 'datafuselabs' && github.ref_name == 'main'
         uses: amondnet/vercel-action@v25.1.1
         with:
           vercel-token: ${{ secrets.VERCEL_TOKEN }}
@@ -48,7 +48,7 @@ jobs:
           working-directory: ./target/book
 
       - name: Deploy to vercel (preview)
-        if: github.ref_name != 'main'
+        if: github.repository_owner == 'datafuselabs' && github.ref_name != 'main'
         uses: amondnet/vercel-action@v25.1.1
         with:
           vercel-token: ${{ secrets.VERCEL_TOKEN }}

diff --git a/.github/workflows/service_test_ipmfs.yml b/.github/workflows/service_test_ipmfs.yml
@@ -17,14 +17,13 @@ concurrency:
 jobs:
   ipmfs:
     runs-on: ubuntu-latest
+    services:
+      ipfs:
+        image: ipfs/go-ipfs:v0.14.0
+        ports:
+          - 5001:5001
     steps:
       - uses: actions/checkout@v3
-      - name: Set up IPFS ${{ matrix.ipfs }}
-        uses: ibnesayeed/setup-ipfs@b9b9f7d73db5f77d462225bb37dbd51153351dd9
-        id: ipfs_setup
-        with:
-          ipfs_version: "v0.14.0"
-          run_daemon: true
       - uses: Swatinem/rust-cache@v2
       - name: Test
         shell: bash

diff --git a/.github/workflows/service_test_redis.yml b/.github/workflows/service_test_redis.yml
@@ -17,11 +17,13 @@ concurrency:
 jobs:
   redis:
     runs-on: ubuntu-latest
+    services:
+      redis:
+        image: redis
+        ports:
+          - 6379:6379
     steps:
       - uses: actions/checkout@v3
-      - uses: shogo82148/actions-setup-redis@v1
-        with:
-          redis-version: "6.x"
       - uses: Swatinem/rust-cache@v2
       - name: Test
         shell: bash

diff --git a/Cargo.toml b/Cargo.toml
@@ -141,7 +141,7 @@ reqwest = { version = "0.11.13", features = [
   "multipart",
   "stream",
 ], default-features = false }
-rocksdb = { version = "0.19", optional = true }
+rocksdb = { version = "0.19", default-features = false, optional = true }
 serde = { version = "1", features = ["derive"] }
 serde_json = "1"
 suppaftp = { version = "4.5", default-features = false, features = [

diff --git a/src/services/rocksdb/backend.rs b/src/services/rocksdb/backend.rs
@@ -30,7 +30,7 @@ use crate::*;
 pub struct Builder {
     /// The path to the rocksdb data directory.
     datadir: Option<String>,
-    /// the working directory of the Redis service. Can be "/path/to/dir"
+    /// the working directory of the service. Can be "/path/to/dir"
     ///
     /// default is "/"
     root: Option<String>,
Benchmark suite	Current: `c99e08b`	Previous: `ee47d96`	Ratio
`service_fs_read_parallel/2x256 KiB`	`298350` ns/iter (`± 26194`)	`131390` ns/iter (`± 9035`)	`2.27`
`service_memory_read_full/256 KiB`	`32410` ns/iter (`± 1000`)	`13122` ns/iter (`± 25`)	`2.47`
`service_memory_write_once/256 KiB`	`99833` ns/iter (`± 3025`)	`44694` ns/iter (`± 206`)	`2.23`