rm if_none_match with *

Signed-off-by: Keming <kemingy94@gmail.com>
apache · Nov 12, 2024 · ce87b81 · ce87b81
1 parent 1272ff1
commit ce87b81
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/core/src/types/operator/operator.rs b/core/src/types/operator/operator.rs
@@ -1247,7 +1247,7 @@ impl Operator {
     /// use opendal::Operator;
     /// # async fn test(op: Operator, etag: &str) -> Result<()> {
     /// let bs = b"hello, world!".to_vec();
-    /// let res = op.write_with("path/to/file", bs).if_none_match("*").await;
+    /// let res = op.write_with("path/to/file", bs).if_none_match(etag).await;
     /// assert!(res.is_err());
     /// assert_eq!(res.unwrap_err().kind(), ErrorKind::ConditionNotMatch);
     /// # Ok(())

diff --git a/core/tests/behavior/async_write.rs b/core/tests/behavior/async_write.rs
@@ -638,9 +638,12 @@ pub async fn test_write_with_if_none_match(op: Operator) -> Result<()> {
     op.write(&path, content.clone())
         .await
         .expect("write must succeed");
+
+    let meta = op.stat(&path).await?;
+
     let res = op
         .write_with(&path, content.clone())
-        .if_none_match("*")
+        .if_none_match(meta.etag().expect("etag must exist"))
         .await;
     assert!(res.is_err());
     assert_eq!(res.unwrap_err().kind(), ErrorKind::ConditionNotMatch);