Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(binding/node.js): basic IO #1416

Merged
merged 20 commits into from
Mar 3, 2023
Merged

feat(binding/node.js): basic IO #1416

merged 20 commits into from
Mar 3, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Feb 26, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

OpenDAL node.js binding
part of #1204

Tasks:

  • Operator
  • Object
  • ObjectMetadata
  • Service Builders
    • Service Memory

Tests:

  • Integration Tests

Project

  • basic CI config(build && test)

Xuanwo
Xuanwo reviewed Feb 26, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I left some comments here, PTAL.

bindings/nodejs/README.md Show resolved Hide resolved
bindings/nodejs/build.rs Outdated Show resolved Hide resolved
bindings/nodejs/package.json Show resolved Hide resolved
bindings/nodejs/rustfmt.toml Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Feb 26, 2023 •
edited
Loading

idea: To make our contribution process more enjoyable and happier, I prefer to discuss the roadmap in #1204 and break it into multiple PRs rather than doing one big PR at a time.

@suyanhanx
Copy link
Member Author

idea: To make our contribution process more enjoyable and happier, I prefer to discuss the roadmap in #1204 and break it into multiple PRs rather than doing one big PR at a time.

SGTM.

Will make this PR focusing on MVP.

@suyanhanx suyanhanx force-pushed the nodejs-binding branch 2 times, most recently from 786c08e to 95a4bf7 Compare March 2, 2023 14:03
Xuanwo
Xuanwo reviewed Mar 2, 2023
View reviewed changes
bindings/nodejs/src/lib.rs Outdated Show resolved Hide resolved
bindings/nodejs/src/lib.rs Outdated Show resolved Hide resolved
bindings/nodejs/src/lib.rs Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Mar 3, 2023

Hi, maybe it worth to take a look over #1464

@suyanhanx
Copy link
Member Author

Great timing! I've been waiting for it!

@suyanhanx suyanhanx changed the title feat: node.js binding feat(binding/node.js): basic IO Mar 3, 2023
suyanhanx added 9 commits March 3, 2023 19:37
@suyanhanx
feat: re-initial node.js binding
4d7e89a 
Signed-off-by: Suyanhanx <suyanhanx@gmail.com>
@suyanhanx
feat(binding): node binding(memory) && test
58d2096 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
chore: Add license
485e8b9 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
chore: fix clippy
5a747d6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
chore: symbolic rustfmt.toml
bde081a 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
feat(package): update package.json/Cargo.toml
d71a0b6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
chore: don't check files's license which generated by napi temporarily
04f58fe 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
chore: remove unused platform
582c81a 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
feat(binding/node.js): update binding func to operator's style
3ca125e 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review March 3, 2023 11:37
Xuanwo
Xuanwo reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We have a working base now!

bindings/nodejs/.github/workflows/CI.yml Outdated Show resolved Hide resolved
bindings/nodejs/__test__/index.spec.mjs Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Mar 3, 2023

The detailed API still need some polish, but I think this PR is a good start!

suyanhanx added 2 commits March 3, 2023 20:18
@suyanhanx
Revert "chore: remove unused platform"
1a4a383 
This reverts commit 582c81a.
@suyanhanx
chore(CI): update bindings-nodejs CI
18031d5 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx and others added 3 commits March 3, 2023 20:51
@suyanhanx
chore(CI): update binding nodejs trigger condition
029cd04 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo
cleanup workflow
2501202 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Merge branch 'nodejs-binding' of https://github.com/suyanhanx/opendal …
a0a7513 
…into nodejs-binding

Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member Author

LGTM. Thanks for your carrying.

Xuanwo added 3 commits March 3, 2023 21:00
@Xuanwo
remove not used steps
3bf52f3 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix build
17fc9c6 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
cleanup
35d75aa 
Signed-off-by: Xuanwo <github@xuanwo.io>
@suyanhanx
Copy link
Member Author

🤣 It's really annoying.

Xuanwo added 3 commits March 3, 2023 21:09
@Xuanwo
FIx run
5930738 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
clean up
a52dc87 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix build
0f9657f 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member

Xuanwo commented Mar 3, 2023

CI, passed! Let's go!

@Xuanwo Xuanwo merged commit 7e0b660 into apache:main Mar 3, 2023
@suyanhanx suyanhanx deleted the nodejs-binding branch March 3, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo