Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Add Copy Support #1841

Merged
merged 3 commits into from
Apr 3, 2023
Merged

feat(core): Add Copy Support #1841

merged 3 commits into from
Apr 3, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Apr 2, 2023 •
edited
Loading

part of #361
Add support to copy and blocking_copy

Currently only the fs implementation is done.

Xuanwo
Xuanwo reviewed Apr 2, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Thanks a lot!

core/examples/object.rs Outdated Show resolved Hide resolved
core/src/layers/logging.rs Show resolved Hide resolved
core/src/types/operator/operator.rs Show resolved Hide resolved
@suyanhanx
feat(core): basic copy and blocking copy
b5394b6 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx
suyanhanx commented Apr 3, 2023
View reviewed changes
core/src/services/fs/backend.rs Show resolved Hide resolved
core/src/types/operator/operator.rs Outdated Show resolved Hide resolved
@suyanhanx suyanhanx marked this pull request as ready for review April 3, 2023 02:24
@suyanhanx suyanhanx requested a review from Xuanwo April 3, 2023 02:34
@suyanhanx
detect support copy or not
12fbefd 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
update same path check
d2d95f9 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx
Copy link
Member Author

As a new capability, I intend to add a new behavioral test.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 3, 2023

As a new capability, I intend to add a new behavioral test.

This PR is good enough to be merged. Maybe we can add behavior test in next PR?

@Xuanwo Xuanwo changed the title feat(core): basic copy feat(core): Add Copy Support Apr 3, 2023
@suyanhanx
Copy link
Member Author

This PR is good enough to be merged. Maybe we can add behavior test in next PR?

LGTM. Will open another.

Xuanwo
Xuanwo approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit c98982e into apache:main Apr 3, 2023
@suyanhanx suyanhanx deleted the fs-cp branch April 3, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo