Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oay): Add basic s3 list_objects_v2 with start_after support #2219

Merged
merged 4 commits into from
May 6, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 6, 2023

No description provided.

Xuanwo added 3 commits April 20, 2023 12:48
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review May 6, 2023 15:44
@Xuanwo Xuanwo requested review from PsiACE, ClSlaid and sundy-li as code owners May 6, 2023 15:44
Signed-off-by: Xuanwo <github@xuanwo.io>
bin/oay/README.md Show resolved Hide resolved
bin/oay/src/bin/oay.rs Show resolved Hide resolved
bin/oay/oay.toml.example Show resolved Hide resolved
bin/oay/src/config.rs Show resolved Hide resolved
bin/oay/src/config.rs Show resolved Hide resolved
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's go!

@Xuanwo Xuanwo merged commit c8222fa into main May 6, 2023
@Xuanwo Xuanwo deleted the add-s3-api branch May 6, 2023 16:35
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
…che#2219)

* feat(oay): Add list objects v2 support

Signed-off-by: Xuanwo <github@xuanwo.io>

* Update

Signed-off-by: Xuanwo <github@xuanwo.io>

* Return error if list with start_after is not supported

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants