Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace futures::ready with std::task::ready #2221

Merged
merged 1 commit into from
May 7, 2023
Merged

refactor: Replace futures::ready with std::task::ready #2221

merged 1 commit into from
May 7, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented May 7, 2023

We could use std::task::ready stabilized at 1.64 as opendal's msrv is 1.64.

Xuanwo
Xuanwo approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 5bc6b84 into apache:main May 7, 2023
@tottoto tottoto deleted the std-task-ready branch May 7, 2023 05:59
suyanhanx pushed a commit to suyanhanx/opendal that referenced this pull request May 8, 2023
@tottoto @suyanhanx
refactor: Replace futures::ready with std::task::ready (apache#2221)
1be3eb4
@Xuanwo Xuanwo mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @Xuanwo